Run CI against rails 7.2 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a specific version of rails require corresponding gem version, it should be in each Gemfile under gemfiles/
mullermp
reviewed
Aug 19, 2024
There was a problem hiding this comment.
I wasn't able to get 7.2 tests to pass either for JRuby. IIRC I made an issue for publishing 7.1: jruby/activerecord-jdbc-adapter#1146. Eventually they will need to support 7.2 ..
|
We will probably need an exception for JRuby 7.2 in the CI matrix. |
mullermp
approved these changes
Aug 20, 2024
|
Thanks for the improvement! |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
This pull request adds Rails 7.2 to the test matrix in CI.
Besides, I reorganized
Gemfileso that each Rails version's Gemfile requires corresponding other gem versions.Note: I wasn't able to pass tests for
activerecord-jdbc-adaptersince they hasn't published any version that accepts Rails 7.2.0.By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.